This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Make Select All respect the visible range#522
Merged
Conversation
Member
|
Looks good to go. Per discussion with NJ, we'll keep the bug (#461) open for now to track filing a CodeMirror bug on the underlying issue that this pull is working around. |
peterflynn
added a commit
that referenced
this pull request
Apr 4, 2012
Make Select All respect the visible range, to work around CodeMirror bug (fixes #461)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@peterflynn
This is a workaround that fixes #461. There's probably an underlying CodeMirror bug that causes that issue, but it seems simple enough to work around it by just explicitly selecting the visible range when we do a Select All.